Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

why is the hour limited to 59?should't it be 23? #21

Closed
dreamfly32 opened this issue Jul 1, 2021 · 2 comments · Fixed by #33
Closed

why is the hour limited to 59?should't it be 23? #21

dreamfly32 opened this issue Jul 1, 2021 · 2 comments · Fixed by #33

Comments

@dreamfly32
Copy link

image
@isoos
Copy link
Contributor

isoos commented Jul 1, 2021

Indeed! Interested in a fix PR? (Please also update changelog with a note)

@myConsciousness myConsciousness mentioned this issue Apr 10, 2022
Merged
@myConsciousness
Copy link
Contributor

I created the PR myself as it appears it has not been maintained for some time.

Please check back when you have time @isoos :)

@myConsciousness myConsciousness mentioned this issue Apr 10, 2022
Merged
@isoos isoos closed this as completed in #33 Apr 10, 2022
isoos pushed a commit that referenced this issue Apr 10, 2022
@myConsciousness
Fix #21 (#33)
edb8bcb
isoos added a commit that referenced this issue Apr 10, 2022
@myConsciousness @isoos
Fix issue #29 (#34)
fe95433 
* Fix #21

* Fix #29

* updated changelog

* async main needs to return Future<void>

Co-authored-by: István Soós <isoos@users.noreply.github.com>
isoos added a commit that referenced this issue Apr 18, 2022
@myConsciousness @isoos
Fix #34 (#37)
c252c9f 
* Fix #21

* Fix #29

* updated changelog

* async main needs to return Future<void>

* fix: fixed #34

* fix: fixed #34

* fix: fixed #34

* fix: fixed #34

Co-authored-by: István Soós <isoos@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #21
3 participants
@isoos @myConsciousness @dreamfly32