Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Particular issue with Google Mixed Content demo page #9

Open
ashfame opened this issue Feb 1, 2018 · 6 comments
Open

Particular issue with Google Mixed Content demo page #9

ashfame opened this issue Feb 1, 2018 · 6 comments

Comments

@ashfame
Copy link
Contributor

ashfame commented Feb 1, 2018

Hi @agis For any URL that I tested with, it works fast and the process ends right after showing the summary. But for this particular URL (the only URL I tested which has mixed content warnings), it hangs up before I get the Error: Navigation Timeout Exceeded: 30000ms exceeded error & then the process ends:

$ node -v && npm -v && ./bin/mcdetect.js https://googlesamples.github.io/web-fundamentals/fundamentals/security/prevent-mixed-content/active-mixed-content.html
v9.4.0
5.6.0
Checking https://googlesamples.github.io/web-fundamentals/fundamentals/security/prevent-mixed-content/active-mixed-content.html ...
	Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/simple-example.js
	Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/style.css
	Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/xmlhttprequest-data.js
	Optionally Blockable: http://googlesamples.github.io/web-fundamentals/samples/discovery-and-distribution/avoid-mixed-content/puppy-thumb.jpg
	Error: Navigation Timeout Exceeded: 30000ms exceeded

Targets checked: 0
Errors (blockable content): 3
Warnings (optionally blockable content): 1

I spent the entire night on it yesterday, only to realize this is happening only with this URL. Or maybe it's happening with all of the mixed content warning pages. Got any clues?

@agis
Copy link
Owner

agis commented Feb 1, 2018

This actually puppeteer/puppeteer#1936. Not sure we can do something about it right now. Want to take a stab?

@BenoitZugmeyer
Copy link

Ha, same issue at the same time :-)

@ashfame
Copy link
Contributor Author

ashfame commented Feb 1, 2018

It's a little above my pay grade right now 😅

@BenoitZugmeyer
Copy link

BenoitZugmeyer commented Feb 1, 2018

For your information, my workaround looks like:

page._frameManager.on("lifecycleevent", frame => {
    if (frame._lifecycleEvents.has("networkIdle") && !frame._lifecycleEvents.has("load")) {
        // Mixed content error
    }
});

@agis
Copy link
Owner

agis commented Apr 12, 2018

@ashfame since the issue is fixed upstream, could you try with the latest puppeteer version?

@ashfame
Copy link
Contributor Author

ashfame commented Apr 12, 2018

@agis Yep, I was subscribed to issue filed on upstream. Going to check it and report back as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants