When a frame fails to load due to a mixed content issue, the main Page is never considered loaded. #1936

BenoitZugmeyer · 2018-01-31T18:33:11Z

Steps to reproduce

Tell us about your environment:

Puppeteer version: 1.0.0
Platform / OS version: ArchLinux (up to date)
URLs (if applicable): https://pste.eu/p/awIC.html
Node.js version: 9.4.0

What steps will reproduce the problem?

Try to load a HTTPS URL including an iframe with a HTTP src (normally blocked with a message like: Mixed Content: The page at '...' was loaded over HTTPS, but requested an insecure resource '...'. This request has been blocked; the content must be served over HTTPS.)

Check this example:

"use strict";
const puppeteer = require("puppeteer");
const url = "https://pste.eu/p/awIC.html";

(async () => {
    const browser = await puppeteer.launch({
        args: [ "--no-sandbox", "--disable-gpu" ]
    });
    const page = await browser.newPage();
    await page.goto(url);
    await browser.close();
})();

Content of https://pste.eu/p/awIC.html

<!DOCTYPE html>
<html>
<head>
    <title></title>
    <meta charset="utf-8" />
</head>
<body>
    <iframe src="http://github.com/"></iframe>
</body>
</html>

What is the expected result?

The page loads. page.goto(...) returns a resolved promise.

What happens instead?

The page never loads. page.goto(...) returns with a rejected promise after a 30 seconds timeout (Error: Navigation Timeout Exceeded: 30000ms exceeded).

Notes

As far as I understand, this is because the iframe never triggers the load event, and the NavigatorWatcher iterates over all iframes to check if a load event occured before resolving the navigationPromise. This issue may need some devtools protocol additions to be fixed.

The text was updated successfully, but these errors were encountered:

BenoitZugmeyer · 2018-02-01T09:53:22Z

Shower thought: on top of this, it would be great to have a "requestfailed" event triggered, in the same way loading a script with a mixed content issue fails.

GregRos · 2018-02-05T19:15:45Z

To be honest, I've found the promise returned by goto to be pretty unreliable in general. I've resorted to injecting some code that manually subscribes to events like DOMContentLoaded and load.

iszmidt · 2018-03-12T17:42:22Z

I'm having the same issue. You can try this workaround:

"use strict";
const puppeteer = require("puppeteer");
const url = "https://pste.eu/p/awIC.html";

(async () => {
    const browser = await puppeteer.launch({
        args: [ "--no-sandbox", "--disable-gpu" ]
    });
    const page = await browser.newPage();
    await page.evaluate((url)=>{window.location = url}, url);
    await page.waitFor('body > iframe');
    console.log('working!');
    await browser.close();
})();

distante · 2018-03-21T11:28:38Z

I'm having the same issue. You can try this workaround:

"use strict";
const puppeteer = require("puppeteer");
const url = "https://pste.eu/p/awIC.html";

(async () => {
    const browser = await puppeteer.launch({
        args: [ "--no-sandbox", "--disable-gpu" ]
    });
    const page = await browser.newPage();
    await page.evaluate((url)=>{window.location = url}, url);
    await page.waitFor('body > iframe');
    console.log('working!');
    await browser.close();
})();

This allow the page to load but there is no way to capture the error.

panthony · 2018-04-06T12:32:44Z

Same issue, tried --allow-running-insecure-content with no luck.

@GregRos Can you somewhat retrieve a response using this method? What was the status code, the HTTP headers, etc?

How do you navigate without goto? Do you use evaluate(() => window.location = url)?

Edit:

I tried something like this instead of using goto, does the work, probably not be bulletproof

    return new Promise((resolve) => {
      let returnValue = null;

     page.on('response', (response) => {
        if (returnValue === null) {
          returnValue = response;
        }
      })

     page.on('domcontentloaded', () => {
        resolve(returnValue);
      })

      return page.evaluate((url) => window.location = url, url);
    });

This patch teaches Page.waitForNavigation to correctly handle navigation to pages that have frames that might never load. These frames include: - frames which main resource loading was aborted due to mixed-content error - frames that artificially called `window.stop()` to interrupt loading themselves Fixes puppeteer#1936.

…nt (#2339) This patch teaches Page.waitForNavigation to correctly handle navigation to pages that have frames that might never load. These frames include: - frames which main resource loading was aborted due to mixed-content error - frames that artificially called `window.stop()` to interrupt loading themselves Fixes #1936.

elainema · 2019-06-21T10:25:09Z

To be honest, I've found the promise returned by goto to be pretty unreliable in general. I've resorted to injecting some code that manually subscribes to events like DOMContentLoaded and load.

Could u pls share that ?

agis mentioned this issue Feb 1, 2018

Particular issue with Google Mixed Content demo page agis/mcdetect#9

Open

othree mentioned this issue Feb 12, 2018

puppeteer error "Cannot find context with specified id undefined" codeceptjs/CodeceptJS#914

Closed

MichaelErmer mentioned this issue Mar 5, 2018

"Mixed Content" error for blocked requests not intercept-able #2142

Closed

aslushnikov added the bug label Apr 10, 2018

aslushnikov mentioned this issue Apr 10, 2018

fix(Page): Page.waitForNavigation should correctly handle mixed content #2339

Merged

aslushnikov closed this as completed in #2339 Apr 10, 2018

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

When a frame fails to load due to a mixed content issue, the main Page is never considered loaded. #1936

When a frame fails to load due to a mixed content issue, the main Page is never considered loaded. #1936

BenoitZugmeyer commented Jan 31, 2018 •

edited

BenoitZugmeyer commented Feb 1, 2018

GregRos commented Feb 5, 2018

iszmidt commented Mar 12, 2018 •

edited

distante commented Mar 21, 2018 •

edited

panthony commented Apr 6, 2018 •

edited

elainema commented Jun 21, 2019

When a frame fails to load due to a mixed content issue, the main Page is never considered loaded. #1936

When a frame fails to load due to a mixed content issue, the main Page is never considered loaded. #1936

Comments

BenoitZugmeyer commented Jan 31, 2018 • edited

Steps to reproduce

Notes

BenoitZugmeyer commented Feb 1, 2018

GregRos commented Feb 5, 2018

iszmidt commented Mar 12, 2018 • edited

distante commented Mar 21, 2018 • edited

panthony commented Apr 6, 2018 • edited

elainema commented Jun 21, 2019

BenoitZugmeyer commented Jan 31, 2018 •

edited

iszmidt commented Mar 12, 2018 •

edited

distante commented Mar 21, 2018 •

edited

panthony commented Apr 6, 2018 •

edited