Package Manager Support for SwiftLMDB #1
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There seems to still be an issue with the generation of Xcode projects. The dependencies between lmdb and SwiftLMDB are not properly Generated to Xcode.
Temporarily hard including the lmdb code base until I figure out how to combine its original folder structure with the package manager Requirements.
|
Hi Erik, Thanks so much for the pull request. As I initially needed only iOS/Mac support, I didn't bother with SPM, but I'm glad you did. I'm happy to merge your changes. I noticed that your CLMDB module contains the |
|
Hi August,
Glad you like it! Love to work on this with you more, as I mentioned I want to add cursors for starters, but things like triggers are also on my wish-list.
The double lmdb.h is because the package manager seems to really want an include folder, while lmdb wants the header at the same place as the .c files. This can maybe be solved by specifying compiler flags in the package manifest, but I haven’t looked into that.
Cheers,
Erik
… On 23 Feb 2017, at 13:28, August Heegaard ***@***.***> wrote:
Hi Erik,
Thanks so much for the pull request. As I initially needed only iOS/Mac support, I didn't bother with SPM, but I'm glad you did. I'm happy to merge your changes.
I noticed that your CLMDB module contains the lmdb.h file twice (in both Sources and Sources/include). Is this necessary?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub <#1 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAwn2zWY15nJ99DSGfRqoePxu7CdpJDYks5rfXt-gaJpZM4MJBc->.
|
|
I see. Maybe a symlink could be used to prevent the duplicates. Otherwise we should just keep things as-is until the SPM becomes a bit less picky. Don't hesitate to create a pull request if you make any headway with the cursors (or other features/fixes). I had something in mind where a database could be made to conform to Sequence/Collection, so that it may be iterated like Array (and friends) from the Swift standard library. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi August,
I've added support for the swift package manager to SwiftLMDB. For this I had to move the C code of lmdb into a separate package (https://github.com/SUIRON/CLMDB). The CLMDB package contains a hard copy of the lmdb source files as the package manager requires there to be an include folder in the right location. So there is room for improvement there.
All your unit tests pass both using 'swift test' as well as in Xcode.
(In case you haven't used the package manager: creating a fresh xcode project can be done with the command: 'swift package generate-xcodeproj' inside the SwiftLMDB package folder).
Anyway, I hope you will consider this pull request. I'm planning to add Cursors to my fork of SwiftLMDB as I need those in my projects.
Cheers,
Erik