Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't test runtime behaviour in buildtime tests. #207

Open
infinity0 opened this issue Oct 15, 2015 · 0 comments
Open

Don't test runtime behaviour in buildtime tests. #207

infinity0 opened this issue Oct 15, 2015 · 0 comments

Comments

@infinity0
Copy link
Contributor

client/tpm/tpm_test.go and client/system/system_test.go test behaviour about the runtime but are unit tests that typically run during build time.

These tests are already present in the main program (e.g. tpmNotPresentMsg, IsSafe, SafeTempDir), so the tests are pointless. In fact I have to disable them in the Debian package because they fail on the build machines, e.g. [1]

[1] https://buildd.debian.org/status/fetch.php?pkg=pond&arch=i386&ver=0.1.1-2&stamp=1444737392

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant