-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows 7 Node v0.8.2 Build Fails #38
Comments
I'm sorry but the windows port is not finished yet. The missing header file |
Not a major issue. |
Has the windows port progressed? |
Nope. No commits, no progress. ;-) On Aug 29, 2012, at 18:45, nickminutello notifications@github.com wrote:
|
I had a look at this two nights ago |
The Windows port boils down to writing a drop-in replacement for IOWatcher (which is deprecated). On the node/libuv side there is a new handle type: poll handles. So, what is needed is something that behaves like the old IOWatcher but uses the new libuv poll code. You can implement that on any platform and just make sure it works on windows afterwards (that's what I would do). The WinsockWatcher already has some of the structure, but should be renamed to SocketWatcher at some point because it will not be windows specific. That is the general plan. Thanks for looking into it! On Aug 29, 2012, at 20:03, Anton Whalley notifications@github.com wrote:
|
So, I started to try to flush out the winsockwatcher as you had started with and stated above, but I seem to have hit a wall for some reason. https://gist.github.com/4082355 -- the .hpp and .cpp I'm trying with (I basically hacked together a bunch of kludges from various sources as well as their own emulator layers to get it to compile and it appears like it SHOULD work) Ultimately I get this error: I'm on node v0.8.14. Not being overly familiar with the node internals, is there something simple I seem to be missing? |
Any further progress on this? |
Thanks @croteb. It's kind of hard to follow whats going on, mostly because of the "emulator layer". Looks like an attempt to make it compatible with old ev_* based code. We're not going to need that. I'd try to strip all the compatibility stuff and only use uv_* calls. Maybe it becomes more obvious what the problem is. I'd also try to follow existing uv_ based code as close as possible (e.g. tcp_wrap from node core). |
@croteb, could you paste some links to the "various sources"? |
I pulled a large majority of the emulation shim framework from joyent themselves (it looks like they were expecting there to be a bunch of 'old way' versus 'new way' and tried to help): I haven't had a chance to get back to this recently -- hopefully in the near future -- , but I did try and comment out a bunch of the code and just do the uv_* calls without much luck. |
Fixed in ef89787 (v1.0.0). mdns now works on windows. Please refer to the installation section of the README for details. Thanks @TobyEalden for providing the PR. Thanks @croteb for putting together the initial gist. |
and on (3.7.5-030705-generic)linux? (dns_sd.h) not found... make: Entering directory |
still report missing "dns_sd.h" error when built under windows 8.1 |
Please see the section on installation in the README. |
Fresh install of 0.8.2
The text was updated successfully, but these errors were encountered: