-
Notifications
You must be signed in to change notification settings - Fork 143
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IOWatcher deprecated #34
Comments
Thanks for the report. That was to be expected. Guess it's time to port to the new libuv poll code then. I'll look into it. I just need to find the time to do so... Thanks again |
+1 |
+1 |
Just wanted to let you guys know that you're not forgotten. In fact this issue is the top priority for the next release. I just have to find the time to actually do it. Thanks for your patience. |
Thanks for the update. Much appreciated that you're on it :) I'd send a PR, but have to admit I'm quite green when it comes to the native side of Node, and apparently we both have very busy schedules :( |
+1 (I'll see if I can PR) |
Cool! You might want to take a look at my last comment in #38. It roughly describes what needs to be done. |
Ah, and also talk to @No9. He wanted to take a look, too. |
Is there any news on this? Would love to get cleaner error logs ;) |
Hey all I put this one on the back burner. I wanted mdns on windows so I could use hook.io. |
+1 would love to see this. |
Hey @jameswomack, that's awesome. A patch would be very welcome. Unfortunately I don't know if such a branch exists. However, please have a look at issue #38. It basically is a different aspect of the same issue (replacing IOWatcher). I commented on what needs doing and @croteb put together a gist. It's not working (yet) but it may be a good starting point... |
Fixed in ef89787 (v1.0.0). On node >=0.7.9 mdns now uses a libuv based SocketWatcher implemented and contributed by @TobyEalden. Thanks! |
Just switched to node 0.8 and pulling in mdns appears to trigger the following warning:
$ node app.js
WARNING: don't use IOWatcher, it'll be removed in v0.9
Per the nodejs blog, iowatcher is being deprecated (http://blog.nodejs.org/2012/06/25/node-v0-8-0/)
The text was updated successfully, but these errors were encountered: