Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: should use ServiceType.prototype.isWildcard #176

Merged
merged 1 commit into from Oct 4, 2016

Conversation

yorkie
Copy link
Contributor

@yorkie yorkie commented Sep 23, 2016

Just make an improvement on function consistence

@agnat agnat merged commit c48648b into agnat:master Oct 4, 2016
@agnat
Copy link
Owner

agnat commented Oct 4, 2016

Thanks.

@yorkie yorkie deleted the improve branch October 4, 2016 04:11
@yorkie
Copy link
Contributor Author

yorkie commented Oct 4, 2016

My pleasure :)

@agnat
Copy link
Owner

agnat commented Oct 4, 2016

Hehe ... unfortunately you didn't test it and it does not actually work:

Browser
/Users/david/projects/node.js/node_mdns/lib/service_type.js:50
  var is_wildcard = ServiceType.isWildcard.call(string)
                                          ^

TypeError: Cannot read property 'call' of undefined
    at ServiceType.fromString (/Users/david/projects/node.js/node_mdns/lib/service_type.js:50:43)
    at new ServiceType (/Users/david/projects/node.js/node_mdns/lib/service_type.js:15:14)
    at Object.makeServiceType (/Users/david/projects/node.js/node_mdns/lib/service_type.js:133:10)
    at new Browser (/Users/david/projects/node.js/node_mdns/lib/browser.js:18:27)
    at Function.create (/Users/david/projects/node.js/node_mdns/lib/browser.js:114:10)
    at module.exports.Browser.Should retrieve interface name from cache when interface index is no longer valid (/Users/david/projects/node.js/node_mdns/tests/test_browser.js:45:88)
    at run_testcase (/Users/david/projects/node.js/node_mdns/utils/testrun:191:3)
    at Array.<anonymous> (/Users/david/projects/node.js/node_mdns/node_modules/slide/lib/bind-actor.js:15:8)
    at LOOP (/Users/david/projects/node.js/node_mdns/node_modules/slide/lib/chain.js:15:14)
    at chain (/Users/david/projects/node.js/node_mdns/node_modules/slide/lib/chain.js:20:5)
npm ERR! Test failed.  See above for more details.

@yorkie
Copy link
Contributor Author

yorkie commented Oct 4, 2016

Sorry @agnat :(

@agnat
Copy link
Owner

agnat commented Oct 4, 2016

No worries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants