Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Differences between inputs for AGN and other systems #817

Open
kslong opened this issue Feb 17, 2021 · 0 comments
Open

Differences between inputs for AGN and other systems #817

kslong opened this issue Feb 17, 2021 · 0 comments

Comments

@kslong
Copy link
Collaborator

kslong commented Feb 17, 2021

Although we have made efforts to make the central object keywords similar, there are different options for central objects in stars and AGN. This is, at root, because a lot of the code for setting up an AGN is seperate from stars. This leads to problems, and should be fixed.

A specific issue however is that whereas one can read in an SED for an AGN, one cannot simply read in and SED for a "star". This should be fixed. (It can be done without addressing the larger problem, but it is an example of the issues the larger problem causes).

Furthermore since one does not normally have both a star and an AGN in a system there are simplifications that should be made by eliminating PTYPES that involve the origin of a photon. (All of this is historical, but if it were fixed, it would make code maintenance simpler.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant