fix: accept any 2xx status code in otlplogshttp client #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simonswine
force-pushed
the
20231025_accept-any-2xx-status-code
branch
from
841a59a
to
1bb1976
Compare
chameleon82
reviewed
Oct 25, 2023
chameleon82
changed the title
This ensure that any 2xx server side response is seen as successful. For example: Grafana Cloud's OTLP gateway will reply with `204` to make it clear there is no body in the response. This is seen as failed without this change.
simonswine
force-pushed
the
20231025_accept-any-2xx-status-code
branch
from
1bb1976
to
1288e8d
Compare
chameleon82
approved these changes
Oct 25, 2023
|
Thank you @simonswine for contribution! |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that any 2xx server side response is seen as successful.
For example: Grafana Cloud's OTLP endpoints will reply with
204to make it clear there is no body in the response. This is seen as failed without this change.