Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gateway: add api to get log status #175

Merged
merged 1 commit into from Nov 13, 2019
Merged

Conversation

camandel
Copy link
Contributor

A try to add "log_archived" field in "RunTaskResponseStep" (#173).

Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@camandel Thanks for your PR!

Some comments inline.

internal/services/gateway/api/run.go Outdated Show resolved Hide resolved
@sgotti
Copy link
Member

sgotti commented Nov 13, 2019

@camandel LGTM. Merging. I created #178 since we need to add some unit tests to these functions.

@sgotti sgotti merged commit 9fd4b66 into agola-io:master Nov 13, 2019
@camandel camandel deleted the api_logarchived branch November 18, 2019 13:20
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
tulliobotti64 pushed a commit to tulliobotti64/agola that referenced this pull request Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants