gateway: add api to get authenticated user organizations #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
2 times, most recently
from
7cdad59
to
5411a9a
Compare
|
Hi Simone, I've just rollback the API's name from /user/{userref}/orgs to /users/{userref}/orgs in configstore and fixed some lint issues on setup_test.go. It is ready to be reviewed. thanks |
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
3 times, most recently
from
a5e0e90
to
d8f42b8
Compare
sgotti
requested changes
Feb 15, 2022
sgotti
changed the title
|
@tulliobotti64 Please also rename the commit to |
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
from
e03912c
to
c01b943
Compare
sgotti
requested changes
Feb 17, 2022
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
5 times, most recently
from
6ba293f
to
7dfc12c
Compare
sgotti
requested changes
Feb 18, 2022
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
from
7dfc12c
to
ec4eab8
Compare
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
from
ec4eab8
to
d0d219c
Compare
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
4 times, most recently
from
60f075a
to
5c737fd
Compare
|
i've run both tests on my pc and I got no error. Can you try to restart Agola's run ? thanks |
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
3 times, most recently
from
c5c3982
to
bc7d9e1
Compare
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
from
bc7d9e1
to
9e32d65
Compare
sgotti
requested changes
Feb 23, 2022
tests/setup_test.go
Outdated
| } | ||
|
|
||
| if diff := cmp.Diff(expectedOrgs, orgs); diff != "" { | ||
| t.Fatalf("user orgs mismatch (-expected +got):\n%s", diff) |
There was a problem hiding this comment.
For consistency use (-want +got)
There was a problem hiding this comment.
done, please review 👍
tests/setup_test.go
Outdated
| @@ -40,6 +40,7 @@ import ( | |||
| gwapitypes "agola.io/agola/services/gateway/api/types" | |||
| gwclient "agola.io/agola/services/gateway/client" | |||
| rstypes "agola.io/agola/services/runservice/types" | |||
| "github.com/google/go-cmp/cmp" | |||
There was a problem hiding this comment.
Move this below with external packages
gateway: add api to get authenticated user organizations gateway: add api to get authenticated user organizations
tulliobotti64
force-pushed
the
16277-filter_user_by_organization
branch
from
9e32d65
to
7160194
Compare
sgotti
approved these changes
Feb 23, 2022
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
…by_organization gateway: add api to get authenticated user organizations
tulliobotti64
pushed a commit
to tulliobotti64/agola
that referenced
this pull request
Oct 19, 2022
…by_organization gateway: add api to get authenticated user organizations
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in the Gateway the API /user/{userref}/orgs
Added some integration tests. Unit tests were done already
To fix the issue #292