db: defer sqlite foreign keys during migration #454
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sqlite provides only limited alter tables capabilities, complex things must be done by creating a new table and migrating the data. Things becomes more complex when other tables references the table being altered. For doing this the documentation provides a list of steps https://www.sqlite.org/lang_altertable.html#making_other_kinds_of_table_schema_changes The first stable is disabling foreign keys, but this must be done outside a transaction. This patch adds this to the migration logic: disable foreign keys outside transaction, check foreign keys before committing the transaction and then re enable them outside the transaction.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sqlite provides only limited alter tables capabilities, complex things must be done by creating a new table and migrating the data. Things becomes more complex when other tables references the table being altered.
For doing this the documentation provides a list of steps https://www.sqlite.org/lang_altertable.html#making_other_kinds_of_table_schema_changes The first stable is disabling foreign keys, but this must be done outside a transaction.
This patch adds this to the migration logic: disable foreign keys outside transaction, check foreign keys before committing the transaction and then re enable them outside the transaction.