Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

notification: delete old run webhooks #457

Merged
merged 1 commit into from
Nov 29, 2023
Merged

notification: delete old run webhooks #457

merged 1 commit into from
Nov 29, 2023

Conversation

alessandro-sorint
Copy link
Contributor

@alessandro-sorint alessandro-sorint commented Nov 20, 2023 •
edited

this patch implements automatic deletion of run webhooks older than the defined interval with a default of 7 days.

@alessandro-sorint alessandro-sorint force-pushed the webhooks-cleaner branch 2 times, most recently from be9fdd4 to 4d45f48 Compare November 21, 2023 09:38
@alessandro-sorint alessandro-sorint changed the title notification: added runWebhooksCleanerLoop for deleting older run webhooks notification: add ability to delete older run webhooks automatically Nov 21, 2023
@alessandro-sorint alessandro-sorint force-pushed the webhooks-cleaner branch 2 times, most recently from 8994e41 to df2417b Compare November 21, 2023 10:07
sgotti
sgotti requested changes Nov 21, 2023
View reviewed changes
tests/setup_test.go Outdated Show resolved Hide resolved
internal/services/notification/webhooks.go Show resolved Hide resolved
sgotti
sgotti requested changes Nov 27, 2023
View reviewed changes
Copy link
Member

@sgotti sgotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this path adds an option to permit the automatic deleting of the older run webhooks. as some typos.

should be
this patch adds an option to enable automatic deletion of run webhooks older than the defined interval.

internal/services/notification/webhooks.go Outdated Show resolved Hide resolved
internal/services/notification/notification_test.go Outdated Show resolved Hide resolved
internal/services/notification/notification_test.go Outdated Show resolved Hide resolved
@alessandro-sorint alessandro-sorint force-pushed the webhooks-cleaner branch 2 times, most recently from ef05063 to b23647f Compare November 27, 2023 11:23
sgotti
sgotti requested changes Nov 27, 2023
View reviewed changes
internal/services/notification/webhooks.go Outdated Show resolved Hide resolved
internal/services/config/config.go Show resolved Hide resolved
@alessandro-sorint alessandro-sorint changed the title notification: add ability to delete older run webhooks automatically notification: delete old run webhooks Nov 27, 2023
@alessandro-sorint alessandro-sorint force-pushed the webhooks-cleaner branch 3 times, most recently from 7238977 to 9eaedf3 Compare November 29, 2023 08:00
@alessandro-sorint
Copy link
Contributor Author

@sgotti can you do the review please?

@alessandro-sorint
notification: delete old run webhooks
b11e838 
this patch implements automatic deletion of run webhooks older than the defined interval with a default of 7 days.
@sgotti sgotti merged commit 3af7f7a into agola-io:master Nov 29, 2023
1 check passed
@alessandro-sorint alessandro-sorint deleted the webhooks-cleaner branch November 29, 2023 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sgotti sgotti sgotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@alessandro-sorint @sgotti