Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

notification: rename GetProjectRunWebhookDeliveriesAfterSequence func #467

Merged
merged 1 commit into from
Dec 15, 2023

Conversation

alessandro-sorint
Copy link
Contributor

@alessandro-sorint alessandro-sorint commented Dec 14, 2023

Rename function GetProjectRunWebhookDeliveriesAfterSequence to GetRunWebhookDeliveriesAfterSequence since it doesn't filter by project.

@sgotti
Copy link
Member

sgotti commented Dec 14, 2023

Rename func GetProjectRunWebhookDeliveriesAfterSequence in GetRunWebhookDeliveriesAfterSequence since it not have project filter.

should be
Rename function GetProjectRunWebhookDeliveriesAfterSequence to GetRunWebhookDeliveriesAfterSequence since it doesn't filter by project.

Please update both commit and PR.

Rename function GetProjectRunWebhookDeliveriesAfterSequence to GetRunWebhookDeliveriesAfterSequence since it doesn't filter by project.
@sgotti sgotti merged commit cfe3b33 into agola-io:master Dec 15, 2023
1 check passed
@alessandro-sorint alessandro-sorint deleted the fixfuncname branch December 15, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants