notification: fix db func GetProjectCommitStatusDeliveriesAfterSequenceByProjectID #468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandro-sorint
force-pushed
the
fix-GetProjectCommitStatusDeliveriesAfterSequenceByProjectID
branch
2 times, most recently
from
60258eb
to
68a21bc
Compare
alessandro-sorint
changed the title
alessandro-sorint
force-pushed
the
fix-GetProjectCommitStatusDeliveriesAfterSequenceByProjectID
branch
3 times, most recently
from
dbdc70b
to
06031ee
Compare
sgotti
reviewed
Dec 19, 2023
| name string | ||
| limit int | ||
| sortDirection types.SortDirection | ||
| deliveryStatus []types.DeliveryStatus |
There was a problem hiding this comment.
what's the purpose of this slice? It wasn't used in previous tests and the logic is totally unclear (only 0 or 1 entries, strange string extraction and comparison...).
There was a problem hiding this comment.
I removed the slice matrix and made the same previous tests logic with the sort order desc
alessandro-sorint
force-pushed
the
fix-GetProjectCommitStatusDeliveriesAfterSequenceByProjectID
branch
2 times, most recently
from
6218f7b
to
a4900c0
Compare
alessandro-sorint
force-pushed
the
fix-GetProjectCommitStatusDeliveriesAfterSequenceByProjectID
branch
2 times, most recently
from
217ff7d
to
417cf12
Compare
…ceByProjectID fix db func GetProjectCommitStatusDeliveriesAfterSequenceByProjectID since startSequence is not provided when the client ask by the first commit status delivery.
alessandro-sorint
force-pushed
the
fix-GetProjectCommitStatusDeliveriesAfterSequenceByProjectID
branch
from
417cf12
to
36be471
Compare
alessandro-sorint
deleted the
fix-GetProjectCommitStatusDeliveriesAfterSequenceByProjectID
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix db func GetProjectCommitStatusDeliveriesAfterSequenceByProjectID since startSequence is not provided when the client ask by the first commit status delivery.