gateway: fix api cursors #471
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sgotti
requested changes
Jan 8, 2024
There was a problem hiding this comment.
@alessandro-sorint Thanks for the PR.
The commits messages should be something like:
gateway: add missing sortdirection to get orgs cursor
the SortDirection field in the returned cursor wasn't set. Set it to the right value.
Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
alessandro-sorint
force-pushed
the
fix-cursors
branch
from
0372dd1
to
70cd999
Compare
sgotti
requested changes
Jan 8, 2024
alessandro-sorint
force-pushed
the
fix-cursors
branch
2 times, most recently
from
e550504
to
30a3203
Compare
sgotti
requested changes
Jan 8, 2024
the SortDirection field in the returned cursor wasn't set. Set it to the right value. Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
the SortDirection field in the returned cursor wasn't set. Set it to the right value. Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
the SortDirection field in the returned cursor wasn't set. Set it to the right value. Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
the SortDirection field in the returned cursor wasn't set. Set it to the right value. Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
the SortDirection field in the returned cursor wasn't set. Set it to the right value. Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
…eries cursor the SortDirection field in the returned cursor wasn't set. Set it to the right value. Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
…ies cursor the SortDirection field in the returned cursor wasn't set. Set it to the right value. Convert tests to matrix tests to reduce code duplication and add tests with both sort directions.
alessandro-sorint
force-pushed
the
fix-cursors
branch
from
30a3203
to
49bb1fc
Compare
sgotti
approved these changes
Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add setting of sort direction to the out cursors.