tests: improve and simplify some tests #483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
sgotti
commented
Feb 7, 2024
•
sgotti
commented
- tests: reuse standard run configs
- tests: improve run configs indentation
- runservice/tests: remove redundant type declaration
- tests: remove "test " prefix from test names
- tests: use commas instead of "and" in test names
- tests: use "limit ... than results length"
- tests: remove not needed time.Sleep
- tests: ensure limit is greater than number of results
- tests: improve TestGetProject*Delivieries
- tests: use assert helpers
sgotti
force-pushed
the
simplify_tests
branch
from
4887b19
to
3f7ab38
Compare
Define a common EnvRunConfig and a FailingRunConfig that will be reused between tests. The first one will print the environment and successfully finish, the second one will fail.
sgotti
force-pushed
the
simplify_tests
branch
2 times, most recently
from
7c05680
to
fbc597f
Compare
It's obvious that a test does a test.
Improve TestGetProjectCommitStatusDeliveries and TestGetProjectRunWebhookDeliveries by: * check for errors when providing both a cursor and a filter * Use multiple calls with cursor when using a filter
Some old PRs weren't rebased to use assert helpers
sgotti
changed the title
sgotti
force-pushed
the
simplify_tests
branch
from
fbc597f
to
e6c966b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.