Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force updated mermaid, markdown-it #63

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

bollwyvl
Copy link
Contributor

@bollwyvl bollwyvl commented Jul 10, 2022

Binder

Elevator Pitch

Updates to markdown-it and @agoose77/markdown-it-mermaid to try out the interplay of some new versions.

References

Changes

  • use hot dev version of `@agoose77/markdown-it-mermaid
    • TODO: remove setup hacks, uses upstream directly
    • adds mermaid to sharedPackages
  • update to markdown-it@^13.0.1
    • TODO: remove resolution
    • TODO: investigate getting @types/markdown-it updated
    • adds markdown-it to sharedPackages
  • deduplicate yarn.lock
    • might not be needed, but was getting some issues (no surprise with the resolution thing)

@bollwyvl bollwyvl marked this pull request as ready for review August 14, 2022 15:46
@bollwyvl bollwyvl marked this pull request as draft August 14, 2022 15:47
@agoose77
Copy link
Owner

I've released a version of markdown-it-mermaid with your PR (1.0.1), which unblocks this?

@bollwyvl
Copy link
Contributor Author

It looks like that release is empty:

https://registry.npmjs.org/@agoose77/markdown-it-mermaid/-/markdown-it-mermaid-1.0.1.tgz

package/
  package.json
  README.md

@agoose77
Copy link
Owner

Yikes. I've re-published 1.0.3, does that look right?

@bollwyvl
Copy link
Contributor Author

It builds locally: we'll see how it goes!

@bollwyvl
Copy link
Contributor Author

Hm, i thought I had bumped the markdown-it on the mermaid upstream: the resolution won't hurt any pre-built users, but downstreams and source users would have to pin it as well to get it right.

@agoose77
Copy link
Owner

@bollwyvl I took the hint and finally released a new version with your changes!

@agoose77 agoose77 marked this pull request as ready for review March 2, 2023 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants