Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statically link release binaries #283

Merged
merged 4 commits into from
Dec 6, 2021
Merged

Conversation

terror
Copy link
Contributor

@terror terror commented Dec 5, 2021

This PR uncurses #269, we believe that there is something wrong with the cache.

@casey
Copy link
Collaborator

casey commented Dec 5, 2021

We gave up on on statically linking arm builds. x86 Ubuntu doesn't include an ARM + musl linker, so we would have had to use cargo cross or install the toolchain ourselves. cargo cross gave us weird errors, so we gave up on that. We could install a arm musl cross compilation toolchain (which would include a linker) ourselves, probably from https://musl.cc. But, we figured that we would much of the benefit of static linking just from doing it on Mac, Linux, and Windows, so that's what this PR does.

@casey
Copy link
Collaborator

casey commented Dec 5, 2021

Pushed a tag.

@casey
Copy link
Collaborator

casey commented Dec 5, 2021

Pushed another tag, which built, so LGTM.

@soenkehahn I'm inclined to merge this. It statically links more binaries, and arm is tricky, so not doing it for now seems like a good idea.

@casey casey merged commit 45527fb into agora-org:master Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants