Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update proc-macro2 to 1.0.33, allow to run tests with cranelift #286

Merged
merged 2 commits into from
Dec 6, 2021

Conversation

soenkehahn
Copy link
Collaborator

This PR allows to run the agora test-suite with cranelift. See https://github.com/bjorn3/rustc_codegen_cranelift/issues/1101.

One obvious advantage of cranelift is that compilation is faster, and one obvious downside is that executing the tests is slower. There may be other implications. So I'm not sure whether running the tests with cranelift is actually a good idea. In any case updating the proc-macro2 version shouldn't hurt, and it allows us to experiment with cranelift.

See also https://github.com/bjorn3/rustc_codegen_cranelift#readme for a description on how to set up cranelift.

@casey
Copy link
Collaborator

casey commented Dec 6, 2021

Sweet! How did you do the selective version bump? I noticed that Cargo.lock changed without Cargo.toml changing, and I don't think I know how to do that for a single dependency.

@soenkehahn
Copy link
Collaborator Author

Sweet! How did you do the selective version bump? I noticed that Cargo.lock changed without Cargo.toml changing, and I don't think I know how to do that for a single dependency.

cargo update -p proc-macro2:1.0.30, where 1.0.30 is the old version, e.g. the version that you want to update.

@soenkehahn soenkehahn marked this pull request as ready for review December 6, 2021 02:25
@soenkehahn soenkehahn merged commit a84e5c4 into master Dec 6, 2021
@soenkehahn soenkehahn deleted the cranelift branch December 6, 2021 02:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants