Skip to content

Commit

Permalink
Fix TieRankingLeaderboard.rank_member_across (#65)
Browse files Browse the repository at this point in the history
  • Loading branch information
GraylinKim authored and czarneckid committed Jun 10, 2019
1 parent 2b832a1 commit 3d49cb0
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 1 deletion.
2 changes: 1 addition & 1 deletion leaderboard/tie_ranking_leaderboard.py
Expand Up @@ -120,7 +120,7 @@ def rank_member_across(
@param member_data [String] Optional member data.
'''
for leaderboard_name in leaderboards:
self.rank_member_in(leaderboard, member, score, member_data)
self.rank_member_in(leaderboard_name, member, score, member_data)

def rank_members_in(self, leaderboard_name, members_and_scores):
'''
Expand Down
6 changes: 6 additions & 0 deletions test/leaderboard/tie_ranking_leaderboard_test.py
Expand Up @@ -230,6 +230,12 @@ def test_it_should_output_the_correct_rank_when_initial_score_is_0_and_then_late
self.leaderboard.rank_for('member_1').should.equal(2)
self.leaderboard.rank_for('member_2').should.equal(2)

def test_rank_member_across(self):
self.leaderboard.rank_member_across(
['highscores', 'more_highscores'], 'david', 50000, {'member_name': 'david'})
len(self.leaderboard.leaders_in('highscores', 1)).should.equal(1)
len(self.leaderboard.leaders_in('more_highscores', 1)).should.equal(1)

def test_it_should_correctly_pop_ties_namespace_from_options(self):
self.leaderboard = TieRankingLeaderboard('ties', ties_namespace='ties_namespace')
self.__rank_members_in_leaderboard(26)
Expand Down

0 comments on commit 3d49cb0

Please sign in to comment.