Fixes #17. Leaderboard not compatible with redis 2.1.1

agoragames · Jun 18, 2012 · 3ad63c8 · 3ad63c8
1 parent 202d980
commit 3ad63c8
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 4 deletions.
diff --git a/CHANGELOG.markdown b/CHANGELOG.markdown
@@ -1,5 +1,9 @@
 # CHANGELOG
 
+## leaderboard 2.2.1 (2012-06-18)
+
+* Fix for #17 - Leaderboard not compatible with redis 2.1.1. Redis' `zrangebyscore` and `zrevrangebyscore` methods do not return scores by default. No need to pass the option in the initial call.
+
 ## leaderboard 2.2.0 (2012-06-18)
 
 * Added `members_from_score_range` and `members_from_score_range_in` methods. These will retrieve members from the leaderboard that fall within a given score range.

diff --git a/lib/leaderboard.rb b/lib/leaderboard.rb
@@ -560,8 +560,8 @@ def members_from_score_range_in(leaderboard_name, minimum_score, maximum_score,
     leaderboard_options.merge!(options)
 
     raw_leader_data = @reverse ? 
-      @redis_connection.zrangebyscore(leaderboard_name, minimum_score, maximum_score, :with_scores => false) :
-      @redis_connection.zrevrangebyscore(leaderboard_name, maximum_score, minimum_score, :with_scores => false)
+      @redis_connection.zrangebyscore(leaderboard_name, minimum_score, maximum_score) :
+      @redis_connection.zrevrangebyscore(leaderboard_name, maximum_score, minimum_score)
 
     if raw_leader_data
       return ranked_in_list_in(leaderboard_name, raw_leader_data, leaderboard_options)

diff --git a/lib/leaderboard/version.rb b/lib/leaderboard/version.rb
@@ -1,4 +1,4 @@
 class Leaderboard
   # Leaderboard version
-  VERSION = '2.2.0'.freeze
+  VERSION = '2.2.1'.freeze
 end
diff --git a/spec/version_spec.rb b/spec/version_spec.rb
@@ -2,6 +2,6 @@
 
 describe 'Leaderboard::VERSION' do
   it 'should be the correct version' do
-    Leaderboard::VERSION.should == '2.2.0'
+    Leaderboard::VERSION.should == '2.2.1'
   end
 end