Skip to content

Commit

Permalink
handlebars.js 0.4.0 breaks helpers with 0 arity. Not sure I feel good…
Browse files Browse the repository at this point in the history
… about this, so this isn't getting released just yet.
  • Loading branch information
hypomodern committed Feb 24, 2013
1 parent b139574 commit 3e97476
Show file tree
Hide file tree
Showing 4 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion spec/controllers/handlebars_controller_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@
assert_response 200

response.should render_template 'with_wrapper'
response.body.should =~ /Yes/
response.body.should =~ /answer: Yes/
ensure
Stache.wrapper_module_name = nil
end
Expand Down
2 changes: 1 addition & 1 deletion spec/dummy/app/views/handlebars/with_wrapper.html.hbs
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
Am I using a wrapper module?

{{answer}}
{{answer 'Yes'}}
4 changes: 2 additions & 2 deletions spec/dummy/lib/wrapper/handlebars/with_wrapper.rb
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
module Wrapper
module Handlebars
class WithWrapper < ::Stache::Handlebars::View
def answer
"Yes"
def answer correct_answer
"answer: #{correct_answer}"
end
end
end
Expand Down
2 changes: 1 addition & 1 deletion stache.gemspec
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ Gem::Specification.new do |s|
s.require_paths = ['lib']

s.add_development_dependency 'mustache'
s.add_development_dependency 'handlebars', '~>0.3.2'
s.add_development_dependency 'handlebars', '~>0.4.0'
s.add_development_dependency 'rails', '~>3.2.0'
s.add_development_dependency 'rspec'
s.add_development_dependency 'rspec-rails'
Expand Down

1 comment on commit 3e97476

@czarneckid
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It might be worth opening an issue on the handlebars.rb project with a link over to this commit.

Please sign in to comment.