Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BUG] Extension Marketplace methods aren't public #46

Closed
maxxfrazer opened this issue Oct 8, 2021 · 1 comment · Fixed by #47
Closed

[BUG] Extension Marketplace methods aren't public #46

maxxfrazer opened this issue Oct 8, 2021 · 1 comment · Fixed by #47
Assignees
@maxxfrazer
Labels
bug Something isn't working Hacktoberfest Hacktoberfest 2021!

Comments

@maxxfrazer
Copy link
Contributor

Describe the bug
Extension marketplace are set to internal (default), should be public

To Reproduce
Steps to reproduce the behavior:
Create AgoraVideoViewer instance and try call the setExtensionProperty methods.

Expected behavior
Methods should be public or open.
@maxxfrazer maxxfrazer added bug Something isn't working Hacktoberfest Hacktoberfest 2021! labels Oct 8, 2021
@maxxfrazer maxxfrazer self-assigned this Oct 8, 2021
@maxxfrazer maxxfrazer mentioned this issue Oct 8, 2021
Merged
15 tasks
@maxxfrazer maxxfrazer linked a pull request Oct 8, 2021 that will close this issue
Public extension #47
Merged
15 tasks
@maxxfrazer
Copy link
Contributor Author

Fixed with #47

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maxxfrazer maxxfrazer

Labels
bug Something isn't working Hacktoberfest Hacktoberfest 2021!
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Public extension AgoraIO-Community/VideoUIKit-iOS
1 participant
@maxxfrazer