Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: only registration window open on first time use #210

Merged
merged 1 commit into from
Mar 28, 2024
Merged

fix: only registration window open on first time use #210

merged 1 commit into from
Mar 28, 2024

Conversation

kieranroneill
Copy link
Contributor

Description

  • Add return statement to exit when handling the case when the extension has not been initialized

Type of change

  • 💥 Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • 🏗️ Build configuration (CI configuration, scaffolding etc.)
  • 🐛 Bug fix (non-breaking change which fixes an issue)
  • 📝 Documentation update(s)
  • 📦 Dependency update(s)
  • 👩🏽‍💻 Improve developer experience
  • ⚡ Improve performance
  • ✨ New feature (non-breaking change which adds functionality)
  • ♻ Refactor
  • ⏪ Revert changes
  • 🧪 New tests or updates to existing tests

@kieranroneill kieranroneill added the 🐛 bug Something isn't working label Mar 28, 2024
@kieranroneill kieranroneill self-assigned this Mar 28, 2024
@kieranroneill kieranroneill linked an issue Mar 28, 2024 that may be closed by this pull request
Main app window opens on first time use #209
Open
@kieranroneill kieranroneill changed the base branch from beta to main March 28, 2024 15:49
@kieranroneill kieranroneill changed the title fix: add return statement to stop handle when registration is initialized fix: only registration window open on first time use Mar 28, 2024
@kieranroneill kieranroneill added this to the v14.0.1 milestone Mar 28, 2024
@kieranroneill kieranroneill merged commit 1e1eea9 into main Mar 28, 2024
9 checks passed
@kieranroneill kieranroneill deleted the 209-main-app-window-opens-on-first-time-use branch March 28, 2024 15:55
github-actions bot pushed a commit that referenced this pull request Mar 28, 2024
@agoralabs-bot
chore(release): 1.14.1
12a0af0 
## [1.14.1](v1.14.0...v1.14.1) (2024-03-28)

### Bug Fixes

* only registration window open on first time use ([#210](#210)) ([1e1eea9](1e1eea9))
@agoralabs-bot
Copy link
Collaborator

🎉 This PR is included in version 1.14.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@agoralabs-bot agoralabs-bot added the 🚀 released To the moon! label Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kieranroneill kieranroneill

Labels
🐛 bug Something isn't working 🚀 released To the moon!
Projects
None yet
Milestone
v1.14.1
Development

Successfully merging this pull request may close these issues.

Main app window opens on first time use
2 participants
@kieranroneill @agoralabs-bot