Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: feature flag for ABCI client type #409

Merged
merged 2 commits into from Apr 12, 2024
Merged

Conversation

JimLarson
Copy link

@JimLarson JimLarson commented Apr 11, 2024

Description

Refs: Agoric/agoric-sdk#9224

Adds a feature flag for selecting the type of ABCI client for a server.

The unit test is shameful, but having no test is more shameful.


Author Checklist

All items are required. Please add a note to the item if the item is not applicable and
please add links to any relevant follow up issues.

I have...

  • included the correct type prefix in the PR title
  • confirmed ! in the type prefix if API or client breaking change
  • targeted the correct branch (see PR Targeting)
  • provided a link to the relevant issue or specification
  • reviewed "Files changed" and left comments if necessary
  • included the necessary unit and integration tests
  • added a changelog entry to CHANGELOG.md
  • updated the relevant documentation or specification, including comments for documenting Go code
  • confirmed all CI checks have passed

Reviewers Checklist

All items are required. Please add a note if the item is not applicable and please add
your handle next to the items reviewed if you only reviewed selected items.

I have...

  • confirmed the correct type prefix in the PR title
  • confirmed all author checklist items have been addressed
  • reviewed state machine logic, API design and naming, documentation is accurate, tests and test coverage

@JimLarson JimLarson added enhancement New feature or request agoric-cosmos Agoric tags for cosmos labels Apr 11, 2024
@JimLarson JimLarson self-assigned this Apr 11, 2024
@JimLarson JimLarson marked this pull request as ready for review April 11, 2024 23:33
@JimLarson
Copy link
Author

Failing lint check is expected - upstream fails too.

Copy link

@gibson042 gibson042 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That is a wild test, but it makes sense and is indeed better than nothing. :shipit:

@JimLarson JimLarson merged commit 26f841f into Agoric Apr 12, 2024
37 of 38 checks passed
@JimLarson JimLarson deleted the 9224-abci-client-flag branch April 12, 2024 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agoric-cosmos Agoric tags for cosmos enhancement New feature or request
Projects
None yet
2 participants