Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Segfaults #1

Closed
firasuke opened this issue Jan 3, 2022 · 10 comments
Closed

Segfaults #1

firasuke opened this issue Jan 3, 2022 · 10 comments
Labels
help wanted Extra attention is needed

Comments

@firasuke
Copy link

firasuke commented Jan 3, 2022

I've downloaded the latest release of dlm, and was greeted with segfaults regardless of what arguments I pass to it, or what values I specify.

@agourlay
Copy link
Owner

Sorry to hear dlm is crashing for you.

Could you please provide more information about the error, I would need a backtrace to investigate the issue.

@firasuke
Copy link
Author

firasuke commented Jan 17, 2022

Thanks for your reply!

  • I downloaded the linux-musl version.
  • I created a file called urls.txt that has 5 different urls, one url per line
  • I tried running dlm with the following flags: ./dlm -i urls.txt -M 3 -o /home/$USER
  • I got the following output: Segmentation fault (core dumped)

@agourlay
Copy link
Owner

Following your reproduction steps, I get a core dumped error as well IF the output path contains a $.

Are you able to confirm that it works with a regular path without the $USER environment variable?

@firasuke
Copy link
Author

I actually had my real user name instead of $USER, and in both cases I get the segmentation fault.

@agourlay
Copy link
Owner

It looks like the Linux binary does not work at all for me either, it was being shadowed by a local build that's why I did not see the problem right away 😭

While I investigate the issue you could workaround the issue by building the binary locally by running the following command in the cloned repository cargo install --path=. -f which will place the binary into /.cargo/bin.

Sorry for the inconvenience and thank you for spotting the issue!

@agourlay agourlay added the help wanted Extra attention is needed label Jan 20, 2022
@agourlay
Copy link
Owner

@vikigenius if you are interested in additional contribution you could have a look at this issue.
No pressure 😉

@agourlay
Copy link
Owner

Have not made progress here.
I will try to setup a different Github action to release x86_64-unknown-linux-gnu binaries.

@agourlay agourlay mentioned this issue Jan 27, 2022
@agourlay
Copy link
Owner

I just tried a new GA to build the Linux binaries and it appears to fix the issue for me!
Please give it a try https://github.com/agourlay/dlm/releases/tag/v0.2.2

@firasuke
Copy link
Author

@agourlay Yup it's working fine now, thanks for your efforts!

@agourlay
Copy link
Owner

Great to hear 👍
Closing the issue!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants