Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

next: Adds options parameter #150

Merged
merged 14 commits into from
Sep 21, 2017
Merged

next: Adds options parameter #150

merged 14 commits into from
Sep 21, 2017

Conversation

lizell
Copy link
Contributor

@lizell lizell commented Sep 21, 2017

Adds options parameter to the CALL_API which is passed to the underlying fetch call. This allows us to control things like network timeouts and redirects, etc.

Example:

{
  [CALL_API]: {
    ...
    options: { timeout: 3000 }
    ...
  }
}

This is somewhat different than #79 that adds the possible options directly on the CALL_API.

This replaces #101 that was the same thing but for 1.x.

@lizell lizell mentioned this pull request Sep 21, 2017
@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage decreased (-1.2%) to 98.844% when pulling a024dd8 on Aftonbladet:next-options-param into 6d9f37e on agraboso:next.

@lizell lizell changed the title Adds options parameter next: Adds options parameter Sep 21, 2017
@coveralls
Copy link

coveralls commented Sep 21, 2017

Coverage Status

Coverage remained the same at 100.0% when pulling 10df9ec on Aftonbladet:next-options-param into 6d9f37e on agraboso:next.

Copy link
Collaborator

@nason nason left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for following up on this @lizell! 👍

@nason nason merged commit a54f17a into agraboso:next Sep 21, 2017
@nason nason added this to the 2.0.0 milestone Sep 21, 2017
@lizell lizell deleted the next-options-param branch September 22, 2017 08:34
@lizell
Copy link
Contributor Author

lizell commented Sep 22, 2017

Great! 😄

@mucsi96
Copy link

mucsi96 commented Oct 31, 2017

@nason Can I kindly ask to release this? please :)

@nason
Copy link
Collaborator

nason commented Oct 31, 2017

@mucsi96 sorry, this one slipped away.

Released in 2.0.0-beta.4

@mucsi96
Copy link

mucsi96 commented Oct 31, 2017

@nason Thank you so much! 🍰 Can I help with anything to merge next to master and release a stable version?

@nason
Copy link
Collaborator

nason commented Nov 20, 2017

@mucsi96 thanks for the offer 💛 ! I finally found some time and cut the 2.0 release.

Please let us know if you run into any issues!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants