New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add action creator for RSAA action #228
Conversation
This gives cleaner boundary for RSAA actions, gives clean API and allows to add validation to action creation process. And this allows for nicer and cleaner typings for Typescript.
Hi @artursvonda, thanks for the contribution! This looks reasonable. Would you mind adding some documentation about this? |
Will do |
Rewrote docs to use |
Should |
Yeah, makes sense. Will add that. If we want to remove the export in some future version, we should I think it makes sense to remove it as long as all use-cases are handled without it. And the only use-case I can think of, that is not yet handled, is getting options from action. But that can be added later if required. |
Done |
Thank you @artursvonda! I'm going to merge and release this as |
Reminder to merge and release this :) |
My bad @artursvonda! So sorry for the delay. I will ship this after after work today! |
Created action creator for cleaner boundary for RSAA actions.
This abstracts shape of the action away from user and allows. And it allows to add validation to action creation process if we choose to (which can be dev build only thing).
This will also allow for nicer and cleaner typings for Typescript.