Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(middleware): use global fetch as last resort #251

Merged
merged 1 commit into from
Mar 18, 2020
Merged

fix(middleware): use global fetch as last resort #251

merged 1 commit into from
Mar 18, 2020

Conversation

iamandrewluca
Copy link
Collaborator

@iamandrewluca iamandrewluca commented Mar 18, 2020

This should behave like v2

In v2 global fetch was used at the moment when action was called. At that moment a global fetch was already provided. If fetch was not provided is was silently catch by try block and dispatched as an failure action.
In v3 we moved that global fetch as a default option. At that moment global fetch was not provided yet, and 'use strict'; complained that fetch does not exist.

Closes #241
Closes #219
Closes #249

@coveralls
Copy link

Coverage Status

Coverage remained the same at 100.0% when pulling 21a550a on iamandrewluca:fix into 4b6a636 on agraboso:master.

@iamandrewluca iamandrewluca merged commit d98422d into agraboso:master Mar 18, 2020
@iamandrewluca iamandrewluca deleted the fix branch March 18, 2020 21:20
@iamandrewluca
Copy link
Collaborator Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ReferenceError: fetch is not defined after upgrading
3 participants