Don't attempt to parse 204 & 205 #49
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Modified `getJSON` will skip parsing JSON response if the response status is either "No Content" or "Reset Content". Presence of `Content-Type` header does not imply presence of response body, therefore it is unsafe to rely on it.
|
I cant release 1.0.0 on NPM because I dont have publish access, nor experience doing that. Depends on when @agraboso is able to do so.. |
|
Ok, we will just have to wait for him then. Thanks :) |
barrystaes
added a commit
that referenced
this pull request
Mar 8, 2016
Don't attempt to parse 204 & 205
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
res.jsonthrows InternalError: "Unexpected end of input" if the response if blank.Modified
getJSONwill skip parsing JSON response if the response status is either "No Content" or "Reset Content". Presence ofContent-Typeheader does not imply presence of response body, therefore it is unsafe to rely on it.