Skip to content

Commit

Permalink
Fix missing log service name for non-rails event catcher
Browse files Browse the repository at this point in the history
The non-rails event catcher was not setting the progname for the
ManageIQ::Loggers instance which defaulted to `"manageiq"`.

This meant that the event catcher logging would be missed if you were
e.g. `journalctl -f -t evm`
  • Loading branch information
agrare committed Mar 11, 2024
1 parent 85314dc commit 3d59be4
Show file tree
Hide file tree
Showing 2 changed files with 7 additions and 4 deletions.
7 changes: 4 additions & 3 deletions workers/event_catcher/event_catcher.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,17 +18,18 @@ def run!

notify_started

logger.info("Collecting events...")
log_prefix = "MIQ(Vmware::InfraManager::EventCatcher)".freeze
logger.info("#{log_prefix} Collecting events...")

wait_for_updates(vim) do |property_change|
logger.info(property_change.name)
logger.info("#{log_prefix} #{property_change.name}")
next unless property_change.name.match?(/latestPage.*/)

events = Array(property_change.val).map do |event|
EventParser.parse_event(event).merge(:ems_id => ems["id"])
end

logger.info(events.to_json)
logger.info("#{log_prefix} events: [#{events.to_json}]")

publish_events(events)
end
Expand Down
4 changes: 3 additions & 1 deletion workers/event_catcher/worker
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,9 @@ end
def main(args)
setproctitle

logger = build_logger
logger = build_logger
logger.progname = "evm"

ems = args["ems"].detect { |e| e["type"] == "ManageIQ::Providers::Vmware::InfraManager" }
messaging = args["messaging"].symbolize_keys
endpoint = ems["endpoints"].detect { |ep| ep["role"] == "default" }
Expand Down

0 comments on commit 3d59be4

Please sign in to comment.