Gracefully handle invalid CSV files #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stdavis
reviewed
Feb 4, 2022
|
This LGTM but I want an approval from @steveoh on my last commit. Then I'm happy to fixup my commit and merge. |
stdavis
previously approved these changes
Feb 4, 2022
|
I'll look at this Monday but will you fix the commit message |
|
steveoh
commented
Feb 7, 2022
steveoh
force-pushed
the
fix/invalid-csv
branch
2 times, most recently
from
a4d810b
to
631368d
Compare
closes #117 Co-Authored-By: steveoh <sgourley@utah.gov>
Includes a refactor to save us a full table scan.
steveoh
force-pushed
the
fix/invalid-csv
branch
from
631368d
to
0b2cba5
Compare
stdavis
approved these changes
Feb 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing
Identify the issue referencing the feature or bug
#117
Description of the Change
Catch the errors and show specific instructions for resolving the problem.