Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix application crash involving request timeouts #130

Merged
merged 3 commits into from
Apr 18, 2022
Merged

Fix application crash involving request timeouts #130

merged 3 commits into from
Apr 18, 2022

Conversation

stdavis
Copy link
Member

@stdavis stdavis commented Apr 15, 2022

Identify the issue referencing the feature or bug

Fixes #122

Description of the Change

  • Bump dependencies including React v18 and Electron v18.
  • Add mock server for testing.
  • Fix bug that was causing timed out requests (and perhaps other reasons for got to throw) to crash the app.

Note: Once this PR is approved and merged, someone needs to upload the new debug symbols to Sentry.

@stdavis stdavis requested a review from steveoh April 15, 2022 15:15
@github-actions github-actions bot added the bug Something isn't working label Apr 15, 2022
@steveoh steveoh changed the title Handle when requests throw errors, bump deps and add mocking server Fix application crash involving request timeouts Apr 18, 2022
@steveoh
Copy link
Member

steveoh commented Apr 18, 2022

Once this PR is approved and merged, someone needs to upload the new debug symbols to Sentry.

This should be done in an action correct?

@stdavis
Copy link
Member Author

stdavis commented Apr 18, 2022

This should be done in an action correct?

That would be nice.

steveoh
steveoh previously approved these changes Apr 18, 2022
@steveoh steveoh merged commit e062fd6 into main Apr 18, 2022
@steveoh steveoh deleted the fix/121 branch April 18, 2022 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error invoking remote method 'geocode': TypeError: Cannot read properties of undefined (reading 'statusCode')
2 participants