Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exp.keyValue() only works with a narrow range of value types #601

Closed
andrus opened this issue Jan 15, 2023 · 0 comments
Closed

Exp.keyValue() only works with a narrow range of value types #601

andrus opened this issue Jan 15, 2023 · 0 comments
Assignees
@stariy95
Labels
bug
Milestone
5.0.M16

Comments

@andrus
Copy link
Contributor

andrus commented Jan 15, 2023 •
edited
Loading

Testing 5.0.M10, and Exp.keyValue() fails e.g. if the value is a LocalDate. I am committing a disabled test here to demonstrate the problem.

io.agrest.AgException: Can't convert value to an expression argument
	at io.agrest.AgException.internalServerError(AgException.java:106)
	at io.agrest.exp.parser.ExpScalar.of(ExpScalar.java:61)
	at io.agrest.protocol.Exp.keyValue(Exp.java:39)

One possible way to fix it is to treat the value as a parameter instead of scalar.
@andrus andrus added the bug label Jan 15, 2023
@andrus andrus added this to the 5.0.M11 milestone Jan 15, 2023
andrus added a commit that referenced this issue Jan 15, 2023
@andrus
Exp.keyValue() only works with a narrow range of value types #601
cc85c5d 
a disabled test to reproduce
@andrus andrus removed this from the 5.0.M11 milestone Jan 27, 2023
m-dzianishchyts added a commit to m-dzianishchyts/agrest that referenced this issue Mar 16, 2023
@m-dzianishchyts
agrestio#601 Exp.keyValue() only works with a narrow range of value t…
40bedf0 
…ypes
m-dzianishchyts added a commit to m-dzianishchyts/agrest that referenced this issue Mar 16, 2023
@m-dzianishchyts
agrestio#601 Exp.keyValue() only works with a narrow range of value t…
b8e6278 
…ypes
andrus added a commit that referenced this issue Apr 10, 2023
@andrus
Exp.keyValue() only works with a narrow range of value types #601
4e41cee 
extra tests
release notes
@andrus andrus added this to the 5.0.M16 milestone Apr 10, 2023
@andrus andrus closed this as completed Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@stariy95 stariy95

Labels
bug
Projects
None yet
Milestone
5.0.M16
Development

No branches or pull requests
2 participants
@andrus @stariy95