Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EntityUpdate-style endpoints behave differently from String and List<EntityUpdate> #609

Closed
andrus opened this issue Feb 10, 2023 · 0 comments
Labels
Milestone

Comments

@andrus
Copy link
Contributor

andrus commented Feb 10, 2023

From these 3 styles of update endpoints:

public SimpleResponse sync(String requestBody)
public SimpleResponse sync(EntityUpdate<T> u)
public SimpleResponse sync(List<EntityUpdate<T>> us)

The first and third variants treat an empty payload as an empty list of updates. While the second one fails with 400 No update. We need to align the behavior between the styles. I think treating this input as valid ("empty list of updates") is the way to go.

@andrus andrus added the bug label Feb 10, 2023
@andrus andrus added this to the 5.0.12 milestone Feb 10, 2023
@andrus andrus closed this as completed Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant