Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exp syntax: function names should not be keywords #654

Closed
andrus opened this issue Sep 26, 2023 · 0 comments · Fixed by #667
Closed

Exp syntax: function names should not be keywords #654

andrus opened this issue Sep 26, 2023 · 0 comments · Fixed by #667
Milestone
5.0-M20

Comments

@andrus
Copy link
Contributor

andrus commented Sep 26, 2023

Looks like function names like "abs" or "substring" are treated as reserved keywords, so for instance you can't have a path called substring. This is needlessly restrictive. We should have a very minimal set of keywords (e.g. "and", "or", "not"). Functions can be easily distinguished from paths by the presense of parenthesis.
@m-dzianishchyts m-dzianishchyts mentioned this issue Feb 5, 2024
Merged
stariy95 added a commit that referenced this issue Feb 6, 2024
@stariy95
Merge pull request #667 from m-dzianishchyts/exp-less-keywords
311c9c0 
Make function names be valid path tokens. Fixes #654.
stariy95 added a commit that referenced this issue Feb 6, 2024
@stariy95
Update RELEASE-NOTES.md
ab7ee11 
#654 Exp syntax: function names should not be keywords
@stariy95 stariy95 added this to the 5.0-M20 milestone Feb 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.0-M20
Development

Successfully merging a pull request may close this issue.

Make function names be valid path tokens m-dzianishchyts/agrest
2 participants
@andrus @stariy95