Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DeleteBuilder: byIds(..), byMultiIds(..) #658

Closed
andrus opened this issue Dec 1, 2023 · 0 comments
Closed

DeleteBuilder: byIds(..), byMultiIds(..) #658

andrus opened this issue Dec 1, 2023 · 0 comments
Milestone

Comments

@andrus
Copy link
Contributor

andrus commented Dec 1, 2023

DeleteBuilder is the only one that supports multiple IDs. Yet its API implies that it only supports one id. byId(..)adds to the id collection, but you need to read the docs to realize that (in SelectBuilder and UpdateBuilder, byId(..) overrides previous ID selection). Need a clearer API:

// DeleteBuilder

// replaces previous IDs collection

DeleteBuilder<T> byIds(Object... ids)
DeleteBuilder<T> byIds(Collection<?> ids)
@andrus andrus changed the title DeleteBuilder.byIds(..) DeleteBuilder: byIds(..), byMapIds(..) Dec 1, 2023
@andrus andrus changed the title DeleteBuilder: byIds(..), byMapIds(..) DeleteBuilder: byIds(..), byMultiIds(..) Dec 1, 2023
andrus added a commit that referenced this issue Dec 1, 2023
@andrus andrus added this to the 5.0-M20 milestone Dec 1, 2023
@andrus andrus closed this as completed Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant