Skip to content

Commit

Permalink
DEP: signal: remove scipy.signal.{lsim2,impulse2,step2} (scipy#19675)
Browse files Browse the repository at this point in the history
* DEP: signal: remove scipy.signal.{lsim2,impulse2,step2}
  • Loading branch information
j-bowhay committed Dec 21, 2023
1 parent b3ba73a commit e72de07
Show file tree
Hide file tree
Showing 7 changed files with 42 additions and 560 deletions.
3 changes: 0 additions & 3 deletions benchmarks/benchmarks/signal.py
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,6 @@ def setup(self):
def time_lsim(self):
signal.lsim(self.system, self.u, self.t)

def time_lsim2(self):
signal.lsim2(self.system, self.u, self.t)

def time_step(self):
signal.step(self.system, T=self.t)

Expand Down
5 changes: 1 addition & 4 deletions doc/source/conf.py
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@

sys.path.insert(0, os.path.abspath(os.path.dirname(__file__)))

import numpydoc.docscrape as np_docscrape # noqa:E402
import numpydoc.docscrape as np_docscrape # noqa: E402

extensions = [
'sphinx.ext.autodoc',
Expand Down Expand Up @@ -322,9 +322,6 @@
plot_pre_code = """
import warnings
for key in (
'lsim2 is deprecated', # Deprecation of scipy.signal.lsim2
'impulse2 is deprecated', # Deprecation of scipy.signal.impulse2
'step2 is deprecated', # Deprecation of scipy.signal.step2
'interp2d` is deprecated', # Deprecation of scipy.interpolate.interp2d
'scipy.misc', # scipy.misc deprecated in v1.10.0; use scipy.datasets
'kurtosistest only valid', # intentionally "bad" excample in docstring
Expand Down
7 changes: 3 additions & 4 deletions doc/source/dev/roadmap-detailed.rst
Original file line number Diff line number Diff line change
Expand Up @@ -307,10 +307,9 @@ things are done in `interpolate`), and eliminate any duplication.

*Filter design*: merge `firwin` and `firwin2` so `firwin2` can be removed.

*Continuous-Time Linear Systems*: remove `lsim2`, `impulse2`, `step2`. The
`lsim`, `impulse` and `step` functions now "just work" for any input system.
Further improve the performance of ``ltisys`` (fewer internal transformations
between different representations). Fill gaps in lti system conversion functions.
*Continuous-Time Linear Systems*: Further improve the performance of ``ltisys``
(fewer internal transformations between different representations). Fill gaps in lti
system conversion functions.

*Second Order Sections*: Make SOS filtering equally capable as existing
methods. This includes ltisys objects, an `lfiltic` equivalent, and numerically
Expand Down
3 changes: 0 additions & 3 deletions scipy/signal/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -172,11 +172,8 @@
TransferFunction -- Linear time invariant system in transfer function form.
ZerosPolesGain -- Linear time invariant system in zeros, poles, gain form.
lsim -- Continuous-time simulation of output to linear system.
lsim2 -- Like lsim, but `scipy.integrate.odeint` is used.
impulse -- Impulse response of linear, time-invariant (LTI) system.
impulse2 -- Like impulse, but `scipy.integrate.odeint` is used.
step -- Step response of continuous-time LTI system.
step2 -- Like step, but `scipy.integrate.odeint` is used.
freqresp -- Frequency response of a continuous-time LTI system.
bode -- Bode magnitude and phase data (continuous-time LTI).
Expand Down
Loading

0 comments on commit e72de07

Please sign in to comment.