Allow multiple spaces in crontab format (#260)

agronholm · Dec 13, 2017 · 89513a7 · 89513a7
1 parent 7cad405
commit 89513a7
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/apscheduler/triggers/cron/__init__.py b/apscheduler/triggers/cron/__init__.py
@@ -95,7 +95,7 @@ def from_crontab(cls, expr, timezone=None):
         :return: a :class:`~CronTrigger` instance
 
         """
-        values = expr.split(' ')
+        values = expr.split()
         if len(values) != 5:
             raise ValueError('Wrong number of fields; got {}, expected 5'.format(len(values)))
 

diff --git a/tests/test_triggers.py b/tests/test_triggers.py
@@ -390,9 +390,12 @@ def test_invalid_ranges(self, values, expected):
          "<CronTrigger (month='*', day='*', day_of_week='*', hour='*', minute='*', "
          "timezone='Europe/Berlin')>"),
         ('0-14 * 14-28 jul fri',
+         "<CronTrigger (month='jul', day='14-28', day_of_week='fri', hour='*', minute='0-14', "
+         "timezone='Europe/Berlin')>"),
+        (' 0-14   * 14-28   jul       fri',
          "<CronTrigger (month='jul', day='14-28', day_of_week='fri', hour='*', minute='0-14', "
          "timezone='Europe/Berlin')>")
-    ], ids=['always', 'assorted'])
+    ], ids=['always', 'assorted', 'multiple_spaces_in_format'])
     def test_from_crontab(self, expr, expected_repr, timezone):
         trigger = CronTrigger.from_crontab(expr, timezone)
         assert repr(trigger) == expected_repr