Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zookeeper jobstore support #144

Merged
merged 6 commits into from Jul 3, 2016
Merged

Zookeeper jobstore support #144

merged 6 commits into from Jul 3, 2016

Conversation

jvillar
Copy link
Contributor

@jvillar jvillar commented May 24, 2016

I'm using Zookeeper for HA coordination of distributed systems and I've implemented a job store for Apscheduler that uses Zookeeper as storage backend.

I've implemented tests and everything seems Ok, with a coverage of 98% for python 2.7 and python 3.4 and all tests passed.

Tox output:

apscheduler/jobstores/zookeeper.py 118 2 98% 127-128
py27: commands succeeded
py34: commands succeeded

@agronholm
Copy link
Owner

Thanks, looks very professional work! I will merge this soonish. Meanwhile, please check why the Travis run failed.

@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage increased (+0.2%) to 93.461% when pulling 3074469 on jvillar:master into 596c679 on agronholm:master.

@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage increased (+0.3%) to 93.508% when pulling 829777a on jvillar:master into 596c679 on agronholm:master.

@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage increased (+0.3%) to 93.508% when pulling 77a1e91 on jvillar:master into 596c679 on agronholm:master.

@coveralls
Copy link

coveralls commented May 24, 2016

Coverage Status

Coverage increased (+0.3%) to 93.508% when pulling 19d8427 on jvillar:master into 596c679 on agronholm:master.

@jvillar
Copy link
Contributor Author

jvillar commented May 24, 2016

Hi!
the problem has already been fixed. When asking for the children of a zookeeper node, Kazoo does not guarantee any order but it was returning an ordered list on my local tests. The order of the entries is now explicitly defined by the zookeeper jobstore class.

@agronholm agronholm merged commit 9eb5dc5 into agronholm:master Jul 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants