Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switched from Travis CI to Github Actions #97

Merged
merged 9 commits into from Oct 1, 2020
Merged

Switched from Travis CI to Github Actions #97

merged 9 commits into from Oct 1, 2020

Conversation

agronholm
Copy link
Owner

This replaces the Travis CI configuration with Github Actions workflows which test the master branch and all pull requests.
In addition, they also automatically build and upload binary wheels and a source distribution to PyPI when you push a tag matching a specific pattern.

@coveralls
Copy link

coveralls commented Sep 29, 2020

Coverage Status

Coverage decreased (-8.9%) to 90.856% when pulling 9e26cdb on workflow into d92b4ba on master.

@Sekenre
Copy link
Collaborator

Sekenre commented Sep 29, 2020

@agronholm Could you change the thresholds on coveralls to allow -1% or -2% change in coverage to pass? It generates lots of false negatives particularly when deleting code.

@agronholm
Copy link
Owner Author

Sure. In this particular case though, it's detecting 0% coverage which is nuts, and I don't know why.

@agronholm
Copy link
Owner Author

I've switched the coverage decrease threshold to 3%.

@agronholm
Copy link
Owner Author

After running the test suite: Coverage.py warning: No data was collected. (no-data-collected). This is despite a detailed coverage chart being printed which indicates 90% coverage. WTF?

This should fix the coverage issue.
@agronholm
Copy link
Owner Author

Ok, that takes care of the coverage problem. The reason coverage fell that much was because I did not include Python 2.7 in the test array. I'll add that too I suppose.

@agronholm
Copy link
Owner Author

I fixed the 2.7 test errors but the highest coveralls version supported on 2.7 is so old it won't work with Github Actions. Bummer. How do you want to handle this?

The required coveralls version does not support Python 2.7.
@Sekenre
Copy link
Collaborator

Sekenre commented Sep 29, 2020

I think tag the current master and update documentation to say this will be the last version tested on 2.7, then merge this PR. How does that sound?

@agronholm
Copy link
Owner Author

Sounds good. You may want to drop support for all Pythons older than 3.6 at the same time since 3.5 has passed its EOL date.

@agronholm
Copy link
Owner Author

Note that you should really drop 2.x compatibility code at the same time; not doing that will lead to 2.x breakage. I can make a PR for that if you want.

@Sekenre
Copy link
Collaborator

Sekenre commented Sep 29, 2020

If you have time that would be awesome!

@agronholm
Copy link
Owner Author

I can probably do that for the Python code but not for the C code as I didn't write any of that.

@waveform80
Copy link
Contributor

Apologies I've been absent for a while! I can try and take a look at integrating coverage for the C bits if wanted; it looks like coveralls has (community contributed) support for gcov output which is what my little coverage script used (lcov is just a gcov front-end).

I think there's still some 3.5 compatibility bits in the C code too which I can excise at the same time.

@Sekenre Sekenre added this to In Progress in Remove Python<=3.5 Sep 30, 2020
@Sekenre Sekenre removed this from In Progress in Remove Python<=3.5 Sep 30, 2020
@Sekenre Sekenre added this to the Remove Python<=3.5 support milestone Sep 30, 2020
@agronholm
Copy link
Owner Author

I guess it's ready to be merged now. I will follow up with a PR that removes other py2.7 specifics.

@Sekenre Sekenre merged commit 86cd497 into master Oct 1, 2020
@agronholm agronholm deleted the workflow branch September 3, 2023 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants