New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switched from Travis CI to Github Actions #97
Conversation
@agronholm Could you change the thresholds on coveralls to allow -1% or -2% change in coverage to pass? It generates lots of false negatives particularly when deleting code. |
Sure. In this particular case though, it's detecting 0% coverage which is nuts, and I don't know why. |
I've switched the coverage decrease threshold to 3%. |
After running the test suite: |
This should fix the coverage issue.
Ok, that takes care of the coverage problem. The reason coverage fell that much was because I did not include Python 2.7 in the test array. I'll add that too I suppose. |
I fixed the 2.7 test errors but the highest coveralls version supported on 2.7 is so old it won't work with Github Actions. Bummer. How do you want to handle this? |
The required coveralls version does not support Python 2.7.
I think tag the current master and update documentation to say this will be the last version tested on 2.7, then merge this PR. How does that sound? |
Sounds good. You may want to drop support for all Pythons older than 3.6 at the same time since 3.5 has passed its EOL date. |
Note that you should really drop 2.x compatibility code at the same time; not doing that will lead to 2.x breakage. I can make a PR for that if you want. |
If you have time that would be awesome! |
I can probably do that for the Python code but not for the C code as I didn't write any of that. |
Apologies I've been absent for a while! I can try and take a look at integrating coverage for the C bits if wanted; it looks like coveralls has (community contributed) support for gcov output which is what my little coverage script used (lcov is just a gcov front-end). I think there's still some 3.5 compatibility bits in the C code too which I can excise at the same time. |
I guess it's ready to be merged now. I will follow up with a PR that removes other py2.7 specifics. |
This replaces the Travis CI configuration with Github Actions workflows which test the master branch and all pull requests.
In addition, they also automatically build and upload binary wheels and a source distribution to PyPI when you push a tag matching a specific pattern.