Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip py311 specific tests #48

Closed
wants to merge 2 commits into from

Conversation

gagath
Copy link

@gagath gagath commented Dec 4, 2022

Tests can be automatically skipped for older Python version (eg. 3.10).

@coveralls
Copy link

coveralls commented Dec 4, 2022

Pull Request Test Coverage Report for Build 3613083071

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 65.463%

Totals Coverage Status
Change from base Build 3577657195: 0.0%
Covered Lines: 2049
Relevant Lines: 3130

💛 - Coveralls

@agronholm
Copy link
Owner

Those aren't even collected on older Pythons. What prompted this PR?

@gagath
Copy link
Author

gagath commented Dec 10, 2022

Those aren't even collected on older Pythons

I was not able to find the part in the code that isolates these tests for older Python versions, hence this PR. Can you show me where this test is ignored for 3.10 in the current code?

What prompted this PR?

This library was packaged into Debian to ease Python version transitions. Debian is trying to switch to 3.11 for its next stable release. So currently both 3.10 and 3.11 version are supported in its rolling release flavor (unstable). This means that this package is currently tested against 3.10 and 3.11 in Debian. It failed to build on 3.10 because our automatic test runner executed this test_catch_py311.py file despite the version being 3.10. Hence this patch was introduced into the package for Debian.

Have a nice day.

@agronholm
Copy link
Owner

I was not able to find the part in the code that isolates these tests for older Python versions, hence this PR. Can you show me where this test is ignored for 3.10 in the current code?

Here: https://github.com/agronholm/exceptiongroup/blob/main/tests/conftest.py#L3-L4

If this wasn't present, the test suite would fail both locally and on GitHub.

automatic test runner executed this test_catch_py311.py

How are you running the tests if not via pytest?

@agronholm agronholm closed this Mar 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants