Add option to bypass SMTPUTF8 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allows email clients to send SMTPUTF8 only for messages where it is required.
cole
changed the title
|
@agronholm any thoughts on this PR? |
|
Sorry, I'll try to get to this over the coming weekend. |
agronholm
requested changes
Apr 9, 2021
src/smtpproto/protocol.py
Outdated
| @@ -100,7 +101,8 @@ def _encode_address(self, address: Union[str, Address]) -> bytes: | |||
| except UnicodeEncodeError: | |||
| raise SMTPProtocolViolation( | |||
There was a problem hiding this comment.
It should be able to tell which one caused the error.
There was a problem hiding this comment.
Ah, good point, thank you. I've added different cases for both of these.
Co-authored-by: Alex Grönholm <alex.gronholm@nextday.fi>
|
@agronholm thanks for the review! I've adopted all suggestions, let me know if I missed anything. I think the test failures are an issue with recent |
|
Pin the aiosmtpd test dependency to the latest version where the tests pass. I'll try to deal with it later. |
Temporary workaround for an issue binding to port 0
agronholm
approved these changes
Apr 15, 2021
|
Thanks! |
agronholm
added a commit
that referenced
this pull request
Jan 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows email clients to send SMTPUTF8 only for messages where it is required.
Should address #3.