ValueError: Empty body on If when defining class under conditional

[rhaps0dy]

Things to check first

• I have searched the existing issues and didn't find my bug already reported there

• I have checked that my bug is still present in the latest release

Typeguard version

3.0.2

Python version

3.10.10

What happened?

The following code causes a crash on import/run.

from typeguard import typechecked

if True:
    class A:
        ...

@typechecked
def f(a: A):
    ...

Prints:

Traceback (most recent call last):
  File ".../repro.py", line 8, in <module>
    def f(a: A):
  File ".../python3.10/site-packages/typeguard/_decorators.py", line 175, in typechecked
    retval = instrument(target)
  File ".../python3.10/site-packages/typeguard/_decorators.py", line 75, in instrument
    module_code = compile(module_ast, f.__code__.co_filename, "exec", dont_inherit=True)
ValueError: empty body on If

And indeed the AST contains an empty If statement. Click to expand.

print(ast.dump(module_ast, indent=4))

Module(
    body=[
        ImportFrom(
            module='typeguard',
            names=[
                alias(name='typechecked')],
            level=0),
        If(
            test=Constant(value=True),
            body=[],
            orelse=[]),
        FunctionDef(
            name='f',
            args=arguments(
                posonlyargs=[],
                args=[
                    arg(
                        arg='a',
                        annotation=Name(id='A', ctx=Load()))],
                kwonlyargs=[],
                kw_defaults=[],
                defaults=[]),
            body=[
                ImportFrom(
                    module='typeguard',
                    names=[
                        alias(name='CallMemo')],
                    level=0),
                ImportFrom(
                    module='typeguard._functions',
                    names=[
                        alias(name='check_argument_types')],
                    level=0),
                Assign(
                    targets=[
                        Name(id='call_memo', ctx=Store())],
                    value=Call(
                        func=Name(id='CallMemo', ctx=Load()),
                        args=[
                            Name(id='f', ctx=Load()),
                            Call(
                                func=Name(id='locals', ctx=Load()),
                                args=[],
                                keywords=[])],
                        keywords=[])),
                Expr(
                    value=Call(
                        func=Name(id='check_argument_types', ctx=Load()),
                        args=[
                            Name(id='call_memo', ctx=Load())],
                        keywords=[])),
                Expr(
                    value=Constant(value=Ellipsis))],
            decorator_list=[])],
    type_ignores=[])

I ran into this bug while running the following:

if TYPE_CHECKING:
    class Something:
        ....
else:
    Something = SomethingElse

Maybe intended behavior, and it's not blocking me, but thought it'd be good to submit.

How can we reproduce the bug?

Paste the code above in a file and run it.

[agronholm]

Have you tried with v4.0.0rc5?

[rhaps0dy]

I just did and it still crashes (though it's python 3.9 now)

[agronholm]

Ok, I'll get it fixed.

[rhaps0dy]

Thank you!! Though don't spend too much time on it, it has a simple workaround: add something else in the if statement.

from typeguard import typechecked

if True:
    ...  # Workaround

    class A:
        ...

@typechecked
def f(a: A):
    ...

[agronholm]

This was caused by an optimization specific to @typechecked. It removed all classes and functions not on the path to the target. It never occurred to me that it could leave a container node without any contents, making it fail compilation.

[agronholm]

This should be fixed now, but if you could confirm that it works for you too, that would be great.

[agronholm]

Oh, and the fix is included in v4.0.0rc6.

[rhaps0dy]

Confirmed fixed, works for me! Thank you very much for resolving it, and so quickly too!