Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for Mock and MagicMock types. #105

Merged
merged 3 commits into from Apr 6, 2020

Conversation

prescod
Copy link
Contributor

@prescod prescod commented Jan 3, 2020

These are analogous to Any, except for values instead of arguments.

Any accepts any value. MagicMock can pretend to be any type.

These are analogous to Any, except for values instead of arguments.

Any accepts any value. MagicMock can pretend to be any type.
@prescod
Copy link
Contributor Author

prescod commented Mar 23, 2020

Hey @agronholm : are you able to take a look at this PR? It's fairly small and you agreed in principle to the approach back in December.

Copy link
Owner

@agronholm agronholm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine, but for the sake of completeness, please use plain Mock in the tests as well as MagicMock.

@agronholm agronholm merged commit 4d5dc39 into agronholm:master Apr 6, 2020
@agronholm
Copy link
Owner

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants