Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Import is_typeddict from typing_extensions if possible #243

Merged
merged 15 commits into from
Apr 18, 2022
Merged

Import is_typeddict from typing_extensions if possible #243

merged 15 commits into from
Apr 18, 2022

Conversation

d-k-bo
Copy link

@d-k-bo d-k-bo commented Mar 2, 2022

Fixes #242.

agronholm and others added 11 commits October 12, 2021 00:20
@agronholm
Fixed @TypeChecked replacing abstract properties with regular properties
8cfbe29 
Fixes agronholm#206.
@agronholm
Fixed Dict-derived classes being mistaken for TypedDict on Python 3.10+
0ec3dad 
Fixes agronholm#216.
@agronholm
Install coverage with toml support in GA test workflow
4ac7f28
@agronholm
Added release date
2516f18
@agronholm
Fixed typing_extensions being imported unconditionally on Python < 3.9
4615f19 
Fixes agronholm#217.
@andyljones
Fixed unwarranted TypeError when run within exec() (agronholm#210)
580826d
@agronholm
Added changelog entry for PR agronholm#210
2fe7a63
@agronholm
Fixed TypedDict checks causing internal TypeError on py3.8 (agronholm…
4c98adc 
…#219)

This works with both native and typing_extensions TypedDicts.

Fixes agronholm#218.
@agronholm
Fixed warning in test_exec_no_namespace()
03db54f
@agronholm
Added release date
de6ab05
@d-k-bo
Import typing_extensions.is_typeddict if possible
42e56d2
@agronholm
Copy link
Owner

All development happens in the 3.0 branch. Is this fix still relevant there?

@agronholm
Copy link
Owner

Also, if this fixes a problem, you need to add a test that would fail without the fix.

@d-k-bo d-k-bo changed the base branch from master to 3.0 April 18, 2022 16:54
@d-k-bo
Copy link
Author

d-k-bo commented Apr 18, 2022

All development happens in the 3.0 branch. Is this fix still relevant there?

I wasn't aware of the 3.0 branch. The issue still persists, but needs to fixed in _utils.py.

Also, if this fixes a problem, you need to add a test that would fail without the fix.

This test on the master branch already fails, since it imports TypedDict from typing_extensions. I added a small that test to the new branch.

@d-k-bo
Copy link
Author

d-k-bo commented Apr 18, 2022

Sorry for all this git mess, I guess it would be better if a opened a new PR.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.6%) to 89.117% when pulling fe1472e on d-k-bo:fix-is-typeddict into 2adc2e9 on agronholm:3.0.

@agronholm agronholm merged commit e0db07a into agronholm:3.0 Apr 18, 2022
@agronholm
Copy link
Owner

Thanks!

@d-k-bo
Copy link
Author

d-k-bo commented Apr 18, 2022

Thanks for merging!

agronholm added a commit that referenced this pull request Apr 27, 2022
@agronholm
Reapplied PR #243 and added a changelog entry
508dab0 
This was lost in the 3.0 merge.
agronholm added a commit that referenced this pull request Apr 27, 2022
@agronholm
Reapplied PR #243 and added a changelog entry
a298d6c 
This was lost in the 3.0 merge.
@agronholm agronholm mentioned this pull request Apr 27, 2022
Closed
@agronholm agronholm mentioned this pull request May 23, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agronholm agronholm agronholm left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

typing_extensions.TypedDict not detected on Python 3.10
4 participants
@d-k-bo @agronholm @coveralls @andyljones