Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shift for any shortcut is probably a bad idea and should be changed #4

Closed
olymk2 opened this issue Mar 22, 2017 · 3 comments
Closed

Comments

@olymk2
Copy link
Contributor

olymk2 commented Mar 22, 2017

Currently I cant type a capital S because its a shortcut and gets replaced with ~~ ~~ I assume I cant use a capital U either for a similar reason.

Can the shortcuts be turned of as a quick fix ?

@agusmakmun
Copy link
Owner

agusmakmun commented Mar 22, 2017

It because this editor used it commands for Underscores and Strikethrough.

editor.commands.addCommand({
    name: 'markdownToUnderscores',
    bindKey: {win: 'Shift-U', mac: 'Option-U'},
    exec: function(editor) {
        markdownToUnderscores()
    },
    readOnly: true
});
editor.commands.addCommand({
    name: 'markdownToStrikethrough',
    bindKey: {win: 'Shift-S', mac: 'Option-S'},
    exec: function(editor) {
        markdownToStrikethrough()
    },
    readOnly: true
});

Perhaps next update I'll change it to Ctrl+Shift+U for Underscores, and Ctrl+Shift+S for Strikethrough, See also this previous release: v1.1.6

Thank you so much for reporting this issue... 👍

@olymk2
Copy link
Contributor Author

olymk2 commented Mar 23, 2017

Yeah that would be great, and definitely needed to allow upper case characters :)

@olymk2
Copy link
Contributor Author

olymk2 commented Apr 11, 2017

great thanks for fixing that :)

Tekkatron pushed a commit to Tekkatron/django-markdown-editor that referenced this issue Sep 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants