Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft: fix: change deprecated bleach to nh3 #202 #209

Closed
wants to merge 5 commits into from

Conversation

agusmakmun
Copy link
Owner

No description provided.

@agusmakmun agusmakmun changed the title fix: change deprecated bleach to nh3 #202 Draft: fix: change deprecated bleach to nh3 #202 Jul 28, 2023
@agusmakmun
Copy link
Owner Author

nh3 only support Python 3.7+.

messense/nh3#20

* `Markdown>=3.0`
* `Markdown<3.4`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe better keep both restrictions, >=3.0 and <3.4?

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still not working, one possible solution is to keep bleach for python <= 3.6, and use nh3 for python >= 3.7.
In the requirements.txt file:

bleach ; python_version < '3.7'
nh3 ; python_version >= '3.7'

But, it also need to change the code.

@agusmakmun
Copy link
Owner Author

withlogicco/django-prose#36 (comment)

We cannot merge this currently, as it's an important decision we need to make calmly. We do have plenty of time, since the maintainers will continue to push security fixes for the foreseeable future, but we certainly need to make a decision here.

Meanwhile, this code will exist in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants